[asterisk-bugs] [JIRA] (ASTERISK-21225) Setting nat=force_rport in [general] sip.conf will never work

[Alexandre Vezina (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=204092#comment-204092 ] 

Alexandre Vezina commented on ASTERISK-21225:
---------------------------------------------

Good job. This patch works great. I tested upon 'restart', 'module reload chan_sip.so' and 'sip reload' and everything works great.

I will have a look a your fix in NAT. Thank you.

I reverted the production to Asterisk 1.8.15 this weekend and I noticed the nat=force_rport,comedia only set the 'Force rport' param and not the 'Symmertric RTP'. So I set nat=yes to fix this. Is your patch compatible with 1.8?

-- May be another case

Also, in 1.8, setting directmedia=nonat sets "DirectMedia : No" and "DirectMedia : Yes" in 11.2.1. I don't know which one is good, but there's a problem there I think.

Last thing, do you think you could add this patch? It would have saved me a lot of time :P. Sorry, I am waiting for my License Agreement: http://pastebin.com/VURAs9j4

Thanks again
                
> Setting nat=force_rport in [general] sip.conf will never work
> -------------------------------------------------------------
>
>                 Key: ASTERISK-21225
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21225
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.2.1
>            Reporter: Alexandre Vezina
>            Assignee: Alexandre Vezina
>            Severity: Minor
>         Attachments: asterisk-21225-handle-options-default-prob_v2.diff
>
>
> I noticed that it was impossible to set nat=force_rport in the general section of sip.conf. It actually has no effect when issuing cli command "sip show settings" (result is Force rport: Auto (No).
> The function to reload configurations in chan_sip.c sets the flag SIP_PAGE3_NAT_AUTO_RPORT in the global flags and the function sip_parse_nat_option in config_parser.c will only add the flag SIP_NAT_FORCE_RPORT if SIP_PAGE3_NAT_AUTO_RPORT is not present.
> So, it seems impossible to raise the flag SIP_NAT_FORCE_RPORT in the [general] section of sip.conf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira