[asterisk-bugs] [JIRA] (ASTERISK-21225) Setting nat=force_rport in [general] sip.conf will never work

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=204023#comment-204023 ] 

Michael L. Young edited comment on ASTERISK-21225 at 3/8/13 10:24 AM:
----------------------------------------------------------------------

Give this patch a try.

Basically, it uses a temporary ast_flags structure to send to handle_common_options.  Then later on we apply those settings to the global_flags.  This way, we override the default settings.

This is how we do this in build_peer.
                
      was (Author: elguero):
    Give this patch a try.

Basically, it creates uses a temporary ast_flags structure to send to handle_common_options.  Then later on we apply those settings to the global_flags.  This way, we override the default settings.

This is how we do this in build_peer.
                  
> Setting nat=force_rport in [general] sip.conf will never work
> -------------------------------------------------------------
>
>                 Key: ASTERISK-21225
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21225
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.2.1
>            Reporter: Alexandre Vezina
>            Assignee: Michael L. Young
>            Severity: Minor
>         Attachments: asterisk-21225-handle-options-default-prob.diff
>
>
> I noticed that it was impossible to set nat=force_rport in the general section of sip.conf. It actually has no effect when issuing cli command "sip show settings" (result is Force rport: Auto (No).
> The function to reload configurations in chan_sip.c sets the flag SIP_PAGE3_NAT_AUTO_RPORT in the global flags and the function sip_parse_nat_option in config_parser.c will only add the flag SIP_NAT_FORCE_RPORT if SIP_PAGE3_NAT_AUTO_RPORT is not present.
> So, it seems impossible to raise the flag SIP_NAT_FORCE_RPORT in the [general] section of sip.conf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira