[asterisk-bugs] [JIRA] (ASTERISK-21209) crash in res_clialiases on reload

[Jaco Kroon (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-21209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jaco Kroon updated ASTERISK-21209:
----------------------------------

    Attachment: asterisk-11.2.1-res_clialiases-segfault.diff

Code has ONLY been compile tested.

Logic basically says that if ast_cli_register fails, give a warning, de-allocate the ao2 object and go on with our lives.
                
> crash in res_clialiases on reload
> ---------------------------------
>
>                 Key: ASTERISK-21209
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21209
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_clialiases
>    Affects Versions: 11.2.1
>            Reporter: Jaco Kroon
>            Severity: Blocker
>         Attachments: asterisk-11.2.1-res_clialiases-segfault.diff
>
>
> Not sure what triggered it, but I got a backtrace that crashed in the hash function for res_clialises, after some static analysis of the code I found that the load_config() function doesn't verify the result of ast_cli_register - which in the case of error de-allocates (it re-allocates cli_entry->command) cli_entry->command and then sets it to NULL, which in turn is used in the hash function to compute the hash.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira