[asterisk-bugs] [JIRA] (ASTERISK-17842) [patch] Building BETTER_BACKTRACES on CentOS 5

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-17842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=207431#comment-207431 ] 

Matt Jordan commented on ASTERISK-17842:
----------------------------------------

So the original patch was committed. An improperly formatted subversion commit message is the reason why this issue is still open.

{quote}
Correct way to do this is to only require those libraries in a separate line, because other distributions do not require those extra libraries (and may choke, if provided [due to duplicate symbols]).
{quote}

I agree with Tilghman - I'd be concerned about unilaterally changing the external library check line without knowing who all it was going to impact. As such, I'd rather not change the script's first check to find the library - we may end up breaking some other distro if we went down that road.

I'm curious why the original check failed on CentOS 5.7 - the way the script is written, it should have attempted to find the library without the {{liberty}} check, and, if it failed, it should have attempted again with the {{liberty}} library. 

{noformat}
AST_EXT_LIB_CHECK([BFD], [bfd], [bfd_openr], [bfd.h])

if test "${PBX_BFD}" = "0"; then
  # Fedora/RedHat/CentOS require extra libraries
  AST_EXT_LIB_CHECK([BFD], [bfd], [bfd_check_format], [bfd.h], [-ldl -liberty])
fi
{noformat}
                
> [patch] Building BETTER_BACKTRACES on CentOS 5
> ----------------------------------------------
>
>                 Key: ASTERISK-17842
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-17842
>             Project: Asterisk
>          Issue Type: Bug
>          Components: General
>            Reporter: Byron Clark
>            Severity: Minor
>         Attachments: 20110512__issue19278.diff.txt, configure_bfd_with_dl_and_iberty.patch
>
>
> In order to detect libbfd and build with BETTER_BACKTRACES, I have to use the attached patch to detect the library. Admittedly, I'm no good with autotools, so there's probably a better way to do this.
> The patch was created against svn trunk, but is also needed on 1.8.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira