[asterisk-bugs] [JIRA] (ASTERISK-13684) [patch] export the SIP peer username of the transferer

[klaus3000 (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=207358#comment-207358 ] 

klaus3000 commented on ASTERISK-13684:
--------------------------------------

You set _transferer as global variable to the called party. But if A calls B, also A could initiate the transfer. Also after a transfer SIPCHANINFO(peername) would always be a wrong name, as the transferer is not in the call anymore.

So I think in this case this might be wrong. Further, I would be careful if the variable magic also works with in complex scenarios after multiple call forwarding and transfers.

My patch should always work, as it fetches the authoritative data (the party who initiated the transfer) directly from the respective SIP structures.
                
> [patch] export the SIP peer username of the transferer
> ------------------------------------------------------
>
>                 Key: ASTERISK-13684
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-13684
>             Project: Asterisk
>          Issue Type: New Feature
>          Components: Channels/chan_sip/NewFeature
>            Reporter: klaus3000
>            Assignee: Olle Johansson
>         Attachments: app_dial--FORWARDER.diff, asterisk-patch-sip-transfer-peername-trunk.txt, patch_chan_sip_transfer_forward_peername-1.4.23.txt, patch_chan_sip_transfer_forward_peername-1.6.2.txt
>
>
> Hi!
> When a blind transfer is initiated from a SIP, often the name of the transferer is needed (e.g. billing, applying restrictions ...). Currently there is a variable called SIPTRANSFER_REFERER which contains the value of the Refered-By header - but this variable is not trustworthy, as the SIP client can put anything into this variable.
> Attached patch adds the variables SIPTRANSFERER_PEERNAME and SIPTRANSFERER_USERNAME which contain the respective SIP username (peer or user)
> ****** ADDITIONAL INFORMATION ******
> As I am not up2date with the current peer/user behavior maybe the SIPTRANSFERER_USERNAME can be removed. I greped the code and it seems that p->peername is also set in case of a SIP user, but not vice versa.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira