[asterisk-bugs] [JIRA] (ASTERISK-22041) Move the ao2 string container to a more appropriate location

[Matt Jordan (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-22041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jordan updated ASTERISK-22041:
-----------------------------------

    Status: Open  (was: Triage)
    
> Move the ao2 string container to a more appropriate location
> ------------------------------------------------------------
>
>                 Key: ASTERISK-22041
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22041
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General
>    Affects Versions: 12
>            Reporter: Matt Jordan
>      Target Release: 12
>
>
> Currently, the ao2 container that contains only strings is directly defined in {{astobj2.h}}. This is an inappropriate location - a specialized container such as this should live in a higher layer of abstraction.
> Unfortunately, it can't live in strings.h without work in the utils folder being done. That being said, it either needs to live in strings.h or somewhere else other than astobj2.
> {noformat}
> /* XXX TODO BUGBUG and all the other things...
>  * These functions should eventually be moved elsewhere, but the utils folder
>  * won't compile with them in strings.h
>  */
> static int str_hash(const void *obj, const int flags)
> {
> 	return ast_str_hash(obj);
> }
> static int str_cmp(void *lhs, void *rhs, int flags)
> {
> 	return strcmp(lhs, rhs) ? 0 : CMP_MATCH;
> }
> struct ao2_container *ast_str_container_alloc_options(enum ao2_container_opts opts, int buckets)
> {
> 	return ao2_container_alloc_options(opts, buckets, str_hash, str_cmp);
> }
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira