[asterisk-bugs] [JIRA] (ASTERISK-20841) fromdomain not honored on outbound INVITE request

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=203076#comment-203076 ] 

Matt Jordan edited comment on ASTERISK-20841 at 7/2/13 10:33 AM:
-----------------------------------------------------------------

I don't have in-depth knowledge of asterisk internals, but a quick look at the code resulted in the following patch which fixed the problem for me:

*\[EDIT: Inline patch removed by mjordan \]*


                
      was (Author: dmitry.panov):
    I don't have in-depth knowledge of asterisk internals, but a quick look at the code resulted in the following patch which fixed the problem for me:

{noformat}
--- chan_sip.c.orig	2013-01-10 00:43:00.000000000 +0400
+++ chan_sip.c	2013-02-15 15:52:44.000000000 +0400
@@ -13744,6 +13744,12 @@
 	else /* Save for any further attempts */
 		ast_string_field_set(p, fromuser, l);
 
+	/* Allow domain to be overridden */
+	if (!ast_strlen_zero(p->fromdomain))
+		d = p->fromdomain;
+	else /* Save for any further attempts */
+		ast_string_field_set(p, fromdomain, d);
+
 	/* Allow user to be overridden */
 	if (!ast_strlen_zero(p->fromname))
 		n = p->fromname;
{noformat}
                  
> fromdomain not honored on outbound INVITE request
> -------------------------------------------------
>
>                 Key: ASTERISK-20841
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20841
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/Interoperability
>    Affects Versions: 1.8.20.0, 11.0.1
>         Environment: ubuntu 12.04
>            Reporter: Kelly Goedert
>         Attachments: debug.txt
>
>
> From David:
> {quote}
> frumuser is now working, but the "presentation not allowed" status is still overriding the from domain. I think that is a bug, but it probably doesn't affect that many people as most ITSPs probably don't check the domain part. The easiest to use ones rely on the IP address, and don't check the user, either. The main advantage of matching on From (type=user in Asterisk terms - but on the other side of the trunk) is that you can use multiple single user accounts, rather than a single business account.
> You may be able to get round it by forcing presentation allowed in the dialplan, or by turning off RPID (so you can't pass caller ID at all).
> However, I think you should report this as a bug.
> {quote}
> http://forums.digium.com/viewtopic.php?f=1&t=85254&start=0&sid=e5fa9f8ef227109f99d7413980fbb0a5

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira