[asterisk-bugs] [JIRA] (ASTERISK-20908) Asterisk presents media desc for video in SDP, missing terminating CRLF

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=202254#comment-202254 ] 

Rusty Newton edited comment on ASTERISK-20908 at 1/26/13 9:19 PM:
------------------------------------------------------------------

Reproduced this with Jitsi 1.0.1 and Asterisk SVN-branch-11-r380043. 

Using reporter's sip.conf (slightly modified to ignore ACLs) I setup a call from Jitsi to a Playback() on Asterisk. 
 
Asterisk presents a media description in the SDP of 200OK to the INVITE like "m=video 0 RTP/AVP 115 34", but with no CRLF to end the record.

Looks like it only occurs when video has been declined.

On test calls where the client supports the codec's defined in sip.conf, the media description and follow attributes appear correct and end with a CRLF.
                
      was (Author: rnewton):
    Reproduced this with Jitsi 1.0.1 and Asterisk SVN-branch-11-r380043. 

Using reporter's sip.conf (slightly modified to ignore ACLs) 
Asterisk presents a media description in the SDP of 200OK to the INVITE like "m=video 0 RTP/AVP 115 34", but with no CRLF to end the record.
                  
> Asterisk presents media desc for video in SDP, missing terminating CRLF
> -----------------------------------------------------------------------
>
>                 Key: ASTERISK-20908
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20908
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.2.0
>         Environment: Fedora 17 - 3.6.11-1.fc17.x86_64 #1 SMP 
>            Reporter: Dennis DeDonatis
>            Assignee: Rusty Newton
>         Attachments: asterisk-20908.diff
>
>
> I tried to use X-Lite 3.0 and before any RTP packets went through, X-Lite would send a Bye.  X-Lite was logging "ParseException dereferenced ParseBuffer eof" in its debug log.
> I tracked it down to the SDP message Asterisk sends for the OK after the INVITE doesn't end with a CRLF.  RFC4566 says "The sequence CRLF (0x0d0a) is used to end a record," so I guess that means the last record should have a CRLF.
> It's exceptionally rare I would use X-Lite 3.0, so this problem may exist in all of v11, but the issue intrigued me enough to track this down.
> I've attached a patch against 11.2.0-rc1, but this most likely isn't the best fix (just tacking a CRLF to the end).  It did prove out that adding a CRLF to the end of the SDP message allows the old X-Lite 3.0 to work with Asterisk 11.2.0-rc1.  11.1.0 has the same problem, although I did not try the patch with it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira