[asterisk-bugs] [JIRA] (DAHLIN-26) [patch] dahdi_dynamic rx buffering, statistics

[Shaun Ruffell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=201954#comment-201954 ] 

Shaun Ruffell commented on DAHLIN-26:
-------------------------------------

Looking into the build failures I saw, it appears that there are changes to include/dahdi/kernel.h that are needed as well?

{noformat}
make -C drivers/dahdi/firmware firmware-loaders
make[1]: Entering directory `/home/sruffell/dahdi-linux/drivers/dahdi/firmware'
make[1]: Leaving directory `/home/sruffell/dahdi-linux/drivers/dahdi/firmware'
make -C /lib/modules/3.2.27/build SUBDIRS=/home/sruffell/dahdi-linux/drivers/dahdi DAHDI_INCLUDE=/home/sruffell/dahdi-linux/include DAHDI_MODULES_EXTRA=" " HOTPLUG_FIRMWARE=yes
make[1]: Entering directory `/home/sruffell/linux-3.2.27'
  CC [M]  /home/sruffell/dahdi-linux/drivers/dahdi/dahdi_dynamic.o
/home/sruffell/dahdi-linux/drivers/dahdi/dahdi_dynamic.c: In function ‘dahdi_dynamic_process_rxfifo’:
/home/sruffell/dahdi-linux/drivers/dahdi/dahdi_dynamic.c:253: error: ‘struct dahdi_dynamic’ has no member named ‘rxfifo_lock’
/home/sruffell/dahdi-linux/drivers/dahdi/dahdi_dynamic.c:253: error: ‘struct dahdi_dynamic’ has no member named ‘rxfifo’
/home/sruffell/dahdi-linux/drivers/dahdi/dahdi_dynamic.c:253: warning: type defaults to ‘int’ in declaration of ‘__tmp’
/home/sruffell/dahdi-linux/drivers/dahdi/dahdi_dynamic.c:253: error: ‘struct dahdi_dynamic’ has no member named ‘rxfifo’
...
{noformat}
                
> [patch] dahdi_dynamic rx buffering, statistics
> ----------------------------------------------
>
>                 Key: DAHLIN-26
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-26
>             Project: DAHDI-Linux
>          Issue Type: Bug
>          Components: dahdi_dynamic
>            Reporter: Pavel Selivanov
>            Assignee: Pavel Selivanov
>         Attachments: dahdi_dynamic.c.#2.patch, dahdi_dynamic.c.patch, dahdi_dynamic.c.printk.patch
>
>
> In current implementation:
> 1. If we have more than one TDMoE device, we'll have a slip/skip. 2 TDMoE devices can have phase jitter.
> 2. We have no statistics (which is necessary).
> 3. ztdynamic can't be a master for zaptel (but why not ?)
> ****** ADDITIONAL INFORMATION ******
> complimentary to
> http://bugs.digium.com/view.php?id=13205
> I'm sure, It's better to use list with pre-allocated buffers (1 memcpy dahdi_dynamic_receive) instead of fifo I've used (2 memcpy, dahdi_dynamic_receive & __ztdynamic_run).
> Or even more, it' better to change dynamic/eth/loc , and use the same idea as skbuff (will have only 1 memcpy on rx, and 1 memcpy on tx{in current version, 2 memcpy on tx})

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira