[asterisk-bugs] [JIRA] (DAHLIN-290) dahdi_dynamic_eth have a huge jitter on transmit

[Pavel Selivanov (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=201941#comment-201941 ] 

Pavel Selivanov commented on DAHLIN-290:
----------------------------------------

{quote}
Ok, perhaps. I thought it would make things clearer to indicate that only the flush of the transmit was happening in the flush_tlet. But, perhaps not.
{quote}
#if is an evil...
In this driver, it will just produce future troubles.

{quote}
I'm not crazy about this, but then I'm not a huge dynamic span user. What I think would be preferable is to make things work reliably without exposing a tuning knob like that. I believe that by just using the flush tasklet, things should be better now, but I could be mistaken.
{quote}
Actually, both modes works reliable.
But one will produce less latency (echo cancel will be done in tasklet), while second will give better system response).

{quote}
Isn't it only called in the context of dahdi_receive? If not, then I agree with you.
{quote}
dahdi_receive could already be called from tasklet/workqueue, of another driver or even dahdi_dummy.
So, dynamic (with timing=0) could be called out of interrupt context.

                
> dahdi_dynamic_eth have a huge jitter on transmit
> ------------------------------------------------
>
>                 Key: DAHLIN-290
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-290
>             Project: DAHDI-Linux
>          Issue Type: Bug
>      Security Level: None
>          Components: dahdi_dynamic_eth
>    Affects Versions: 2.6.1
>         Environment: tasklets enabled in dahdi_dynamic.c (#define ENABLE_TASKLETS)
>            Reporter: Pavel Selivanov
>            Assignee: Pavel Selivanov
>         Attachments: 0001-dahdi_dynamic-Use-a-tasklet-for-flushing-dynamic-dri.patch, 0002-Revert-dahdi_dynamic_eth-Move-tx-packet-flushing-to-.patch, dahdi_dynamic.c.patch, dahdi_dynamic_eth.c.patch
>
>
> At r10562 "Move tx packet flushing to process context".
> Seems, using a common "thread" can produce a huge jitter.
> Since this "common" thread can be used by any driver - it can't guarantee 1ms...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira