[asterisk-bugs] [JIRA] (DAHLIN-26) [patch] dahdi_dynamic rx buffering, statistics

[Shaun Ruffell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=201911#comment-201911 ] 

Shaun Ruffell commented on DAHLIN-26:
-------------------------------------

Just FYI, I haven't looked closely at the new patch but it didn't compile. At least against 3.2.27 (I haven't tried any other releases).

Also, when I run it though the kernel [checkpatch.pl|http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=scripts/checkpatch.pl] script, I get the following summary:
total: 45 errors, 34 warnings, 425 lines checked

Care to fix that up?
                
> [patch] dahdi_dynamic rx buffering, statistics
> ----------------------------------------------
>
>                 Key: DAHLIN-26
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-26
>             Project: DAHDI-Linux
>          Issue Type: Bug
>          Components: dahdi_dynamic
>            Reporter: Pavel Selivanov
>            Assignee: Pavel Selivanov
>         Attachments: dahdi_dynamic.c.#2.patch, dahdi_dynamic.c.patch, dahdi_dynamic.c.printk.patch
>
>
> In current implementation:
> 1. If we have more than one TDMoE device, we'll have a slip/skip. 2 TDMoE devices can have phase jitter.
> 2. We have no statistics (which is necessary).
> 3. ztdynamic can't be a master for zaptel (but why not ?)
> ****** ADDITIONAL INFORMATION ******
> complimentary to
> http://bugs.digium.com/view.php?id=13205
> I'm sure, It's better to use list with pre-allocated buffers (1 memcpy dahdi_dynamic_receive) instead of fifo I've used (2 memcpy, dahdi_dynamic_receive & __ztdynamic_run).
> Or even more, it' better to change dynamic/eth/loc , and use the same idea as skbuff (will have only 1 memcpy on rx, and 1 memcpy on tx{in current version, 2 memcpy on tx})

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira