[asterisk-bugs] [JIRA] (ASTERISK-20742) [patch] Log callers entering/leaving MOH.

[Steve Murphy (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-20742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Murphy updated ASTERISK-20742:
------------------------------------

    Attachment: qlogholdtime.patch

This new patch hopefully passes muster for the folks who would like to see the work of logging being done within the confines of app_queue via callbacks.

The goal was to use callbacks, and also, to use standard components to do so. Using ast_event seemed natural, as it is already being used in app_queue.

I went perhaps one step further than required, in that I saw that queue_log was being called from within chan_agent. Now, it isn't that unnatural that chan_agent is calling queue_log, after all it *is* a queue-related chunk of code! But, really, it seemed to me a little inconsistent, that such an app_queue specific action is being called from another module. So, it used the same event call-back mechanism to pull all queue logging back into app_queue. If this is seen as a negative thing, I can revert the chan_agent and app_queue code fairly easily to remove this.

Since the filtering is done in app_queue, you will see that I implemented a hash table for the channels that have been connected to agents. For queues with large memberships, and high call rates, this will be a definite performance advantage.

                
> [patch] Log callers entering/leaving MOH.
> -----------------------------------------
>
>                 Key: ASTERISK-20742
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20742
>             Project: Asterisk
>          Issue Type: New Feature
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: SVN, 12
>         Environment: all
>            Reporter: Steve Murphy
>            Severity: Trivial
>         Attachments: qlogholdtime.patch, qonhold.trunk.diff, qonholdv2.trunk.diff
>
>
> This patch will allow incoming calls to track the time they are put on hold (MOH). This does not count MOH played before an agent accepts the call.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira