[asterisk-bugs] [JIRA] (ASTERISK-20908) SDP doesn't end with CRLF

[Dennis DeDonatis (JIRA)]

Dennis DeDonatis created ASTERISK-20908:
-------------------------------------------

             Summary: SDP doesn't end with CRLF
                 Key: ASTERISK-20908
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20908
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_sip/General
    Affects Versions: 11.2.0
         Environment: Fedora 17 - 3.6.11-1.fc17.x86_64 #1 SMP 
            Reporter: Dennis DeDonatis


I tried to use X-Lite 3.0 and before any RTP packets went through, X-Lite would send a Bye.  X-Lite was logging "ParseException dereferenced ParseBuffer eof" in its debug log.

I tracked it down to the SDP message Asterisk sends for the OK after the INVITE doesn't end with a CRLF.  RFC4566 says "The sequence CRLF (0x0d0a) is used to end a record," so I guess that means the last record should have a CRLF.

It's exceptionally rare I would use X-Lite 3.0, so this problem may exist in all of v11, but the issue intrigued me enough to track this down.

I've attached a patch against 11.2.0-rc1, but this most likely isn't the best fix (just tacking a CRLF to the end).  It did prove out that adding a CRLF to the end of the SDP message allows the old X-Lite 3.0 to work with Asterisk 11.2.0-rc1.  11.1.0 has the same problem, although I did not try the patch with it.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira