[asterisk-bugs] [JIRA] (ASTERISK-21191) VoiceMailPlayMsg doesn't work with ODBC

[acheck (JIRA)]

acheck created ASTERISK-21191:
---------------------------------

             Summary: VoiceMailPlayMsg doesn't work with ODBC
                 Key: ASTERISK-21191
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21191
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Applications/app_voicemail/ODBC
    Affects Versions: 11.2.0
         Environment: CentOS 6.3
            Reporter: acheck


Function play_message_by_id_helper which is used to play message for VoiceMailPlayMsg doesn't play anything in case of ODBC (probably with IMAP too) - it doesn't have code to retrieve recording to the file. It also has double call to make_file() - probably typo.

Following patch will help:

--- app_voicemail.c.orig        2013-01-18 05:26:17.000000000 +0400
+++ app_voicemail.c     2013-02-27 15:46:03.000000000 +0400
@@ -10629,7 +10629,6 @@
        /* Found the msg, so play it back */
 
        make_file(vms->fn, sizeof(vms->fn), vms->curdir, vms->curmsg);
-       make_file(vms->fn, sizeof(vms->fn), vms->curdir, vms->curmsg);
 
 #ifdef IMAP_STORAGE
        /*IMAP storage stores any prepended message from a forward
@@ -10639,6 +10638,9 @@
                wait_file(chan, vms, vms->introfn);
        }
 #endif
+
+       RETRIEVE(vms->curdir, vms->curmsg, vmu->mailbox, vmu->context);
+
        if ((wait_file(chan, vms, vms->fn)) < 0) {
                ast_log(AST_LOG_WARNING, "Playback of message %s failed\n", vms->fn);
        } else {
@@ -10650,6 +10652,7 @@
                ast_mutex_unlock(&vms->lock);
 #endif
        }
+       DISPOSE(vms->curdir, vms->curmsg);
 
        return 0;
 }


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira