[asterisk-bugs] [JIRA] (ASTERISK-20904) RFC1918 NAT Issue On Prune

[Mark Michelson (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=203537#comment-203537 ] 

Mark Michelson commented on ASTERISK-20904:
-------------------------------------------

I gave the new patch a quick look and nothing looks harmful there. In transmit_response_using_temp(), it doesn't really seem necessary to copy AUTO_COMEDIA or SYMMETRIC_RTP flags because the function is only used in order to transmit an error response using a temporary sip_pvt struct. There should be no media involved at all. However, it makes sense to set the AUTO_RPORT flag though.

The other changes all look perfectly fine to me. Thanks for keeping in mind the CHANGES file as well!
                
> RFC1918 NAT Issue On Prune
> --------------------------
>
>                 Key: ASTERISK-20904
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20904
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.2.0
>            Reporter: JoshE
>            Assignee: Michael L. Young
>         Attachments: asterisk-20904-auto-nat-prune_v1.diff, asterisk-20904-nat-auto-and-rt-peers.diff, rfc1918_patch.diff
>
>
> Issue is related to ASTERISK-20572, but appears to have been reintroduced in Asterisk 11.x.
> Bring up a realtime peer behind separated from the Asterisk server behind NAT.   When the peer is pruned and brought back up, the peer's external NAT address is replaced with the private IP from the contact header, if that address was present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira