[asterisk-bugs] [JIRA] (ASTERISK-21065) Asterisk 11 IPv6 - FastAGI fail

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=202989#comment-202989 ] 

Michael L. Young edited comment on ASTERISK-21065 at 2/14/13 5:16 PM:
----------------------------------------------------------------------

Yep, it will log a warning every time the connect fails... I thought it might help a user to know that it is trying multiple addresses.  If it is too verbose, we can always change it.

The patch is kind of using errno for two purposes.  Like you mentioned, getsockopt(2) can return negative and errno will be the error.  If there is no error, then errno will be set to SO_ERROR.  I am only checking errno since I am using it for a dual purpose.  I could always change that if it is confusing.  I just may do that anyway for code readability purposes.

I created this patch against 11 and will put it up for review as a bug fix.  I can see that the intent of the code was to have this behavior so I think it is just a behavior that was there but not working properly, rather than a new feature.
                
      was (Author: elguero):
    Yep, it will log an error... I thought it might help a user to know that it is trying multiple addresses.  If it is too verbose, we can always change it.

The patch is kind of using errno for two purposes.  Like you mentioned, getsockopt(2) can return negative and errno will be the error.  If there is no error, then errno will be set to SO_ERROR.  I am only checking errno since I am using it for a dual purpose.  I could always change that if it is confusing.  I just may do that anyway for code readability purposes.

I created this patch against 11 and will put it up for review as a bug fix.  I can see that the intent of the code was to have this behavior so I think it is just a behavior that was there but not working properly, rather than a new feature.
                  
> Asterisk 11 IPv6 - FastAGI fail
> -------------------------------
>
>                 Key: ASTERISK-21065
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21065
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_agi
>    Affects Versions: 11.2.1
>            Reporter: Jeremy Kister
>            Assignee: Jeremy Kister
>         Attachments: 21065-1.patch, asterisk-21065_poll_correctly.diff, console_debug.txt, console.txt, extensions.conf
>
>
> exten => 1,1,AGI(agi://localhost/foo) always fails with "Connect failed"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira