[asterisk-bugs] [JIRA] (ASTERISK-21046) res_xmpp refcount issue

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=202942#comment-202942 ] 

Matt Jordan commented on ASTERISK-21046:
----------------------------------------

So, the patch is bogus. I'd throw that away :-)

I still don't think there's a real ref leak here. The client configuration objects are managed by a global container (globals), which is created on module load and disposed of on module unload (via {{ao2_global_obj_release(globals);}}). The destructor for the global container {{xmpp_config_destructor}} disposes of the client configuration objects container, which should individually remove the last reference on each of the objects. The fact that during operation, the reference count on the global container toggles between 1 and 2 indicates that the reference count is where it should be - it's 1 when nothing is trying to get the global container, and 2 when something has obtained it.

It's possible that during shutdown the log file just doesn't display the reference going to 0 because the file was closed out during the unload operation. I'd try loading the module, letting it run, then explicitly unloading it.
                
> res_xmpp refcount issue
> -----------------------
>
>                 Key: ASTERISK-21046
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21046
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_xmpp
>    Affects Versions: 11.2.1
>         Environment: i386 Linux
>            Reporter: marcelloceschia
>            Assignee: marcelloceschia
>            Severity: Critical
>         Attachments: refs.tar.gz
>
>
> xmpp_client_reconnect does not release obj reference

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira