[asterisk-bugs] [JIRA] (ASTERISK-23035) ConfBridge with name longer than max (32 chars) results in several bridges with same conf_name

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-23035:
-------------------------------------

    Attachment: confbridge-enforce_max-11up.patch
                confbridge-enforce_max-1.8.patch

Patch to reject conference name's that are too long.  The storage size has been increased to AST_MAX_EXTENSION.

Also adds protection against an odd error case:
same => n,ConfBridge(${EMPTY_VAR},default)

Instead of checking for empty 'data' the updated code checks for empty first parameter.

I've compiled with this in 1.8/11/12. Runtime testing was done with 11.
                
> ConfBridge with name longer than max (32 chars) results in several bridges with same conf_name
> ----------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-23035
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-23035
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_confbridge
>    Affects Versions: 12.0.0-beta2
>            Reporter: Iñaki Cívico
>            Severity: Minor
>         Attachments: confbridge-enforce_max-11up.patch, confbridge-enforce_max-1.8.patch
>
>
> This simple dialplan is used to reproduce issue:
> exten => _X.,1,ConfBridge(${confid})
> where confid is longer than MAX_CONF_NAME (apps/confbridge/include/confbridge.h)
> Each time a call arrives to this point, a new bridge is created with same name (confid truncated to MAX_CONF_NAME length) but different uuid.
> In app_confbridge/join_conference_bridge, ao2_find() searches with full conference name (longer than max length). ao2_find result is always null as bridge has a truncated name, then a new bridge is created with the same name.
> Behavior is extrange resulting in a several calls connected to the same conf but not earing each other. Here is a console trace:
> CLI> confbridge list
> Conference Bridge Name           Users  Marked Locked?
> ================================ ====== ====== ========
> 7e012c4d-9f34-4628-a483-c152ad5       1      0 unlocked
> 7e012c4d-9f34-4628-a483-c152ad5       1      0 unlocked

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira