[asterisk-bugs] [JIRA] (ASTERISK-22954) [patch] Incorrect treatment of amaflags, accountcode and userfield since ASTERISK-16990

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=212880#comment-212880 ] 

Matt Jordan commented on ASTERISK-22954:
----------------------------------------

I enjoy the fact that this right after the comment "this is why you never touch CDR code." :-)

But I agree with your assessment. The point of that code block is to copy over the properties that were changed while the channel was bridged (which would typically happen due to dynamic features) to the CDR that will be posted - but if we happened to have been masqueraded away, what we have on the channel is not what we want.

So, in theory at least, the patch looks good.

But it is CDRs... we should probably run this through the Asterisk Test Suite at a minimum, and it'd be nice to get a few others to verify it.
                
> [patch] Incorrect treatment of amaflags, accountcode and userfield since ASTERISK-16990
> ---------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22954
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22954
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: CDR/General
>    Affects Versions: 1.8.24.0, 10.12.3, 11.6.0
>            Reporter: Steve Davies
>         Attachments: patches_1.8_10_11.diff
>
>
> During a blind transfer, or any other event that causes a channel masquerade, CDR records are swapped. The change made in ASTERISK-16990 (https://reviewboard.asterisk.org/r/1721/) does not take this into account.
> This results in the amaflags, accountcode and userfield data for a completely unrealted call leg being copied into a bridge_cdr, just before it is sent to the database :(
> It would almost be better if that patch had never been applied - Looking through the changelog, it has had a couple of knock on effects which are already patched.
> (Not sure if this applies to version 12 as the bridge code is so changed.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira