[asterisk-bugs] [JIRA] (ASTERISK-22428) SIP unregister does not fully unregister when using Realtime sip peers

[Michael L. Young (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-22428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael L. Young updated ASTERISK-22428:
----------------------------------------

    Attachment: asterisk-22428-dont-update-unregistered-peer.diff

Give this patch a try and please provide feedback on what you think or if this works.

I did some testing with it and everything appears to be working properly.  I ended up modifying the first patch I had in order to work properly in the case where RT Caching is turned off.

I am still curious to see your patch though and see if we came to the same conclusion as to how to fix it.

Thanks
                
> SIP unregister does not fully unregister when using Realtime sip peers
> ----------------------------------------------------------------------
>
>                 Key: ASTERISK-22428
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22428
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>    Affects Versions: 1.8.23.0, 11.5.0
>            Reporter: Ben Smithurst
>            Severity: Minor
>         Attachments: after.pcap, asterisk-22428-dont-update-unregistered-peer.diff, before.pcap, console_after.txt, console_before.txt
>
>
> When a SIP phone unregisters, this does not seem to be fully saved back to the DB when using realtime.  I see that the ipaddr and port fields are cleared, but regseconds and fullcontact are not, so the registration still works.  Asterisk seems to know it is unregistering, as it logs 'Unregistering SIP xxx' on the console.
> In console_before.txt you can see that after unregister, a call is placed, and the call is routed to the extension, but in console_after.txt it immediately says everyone is busy/congested, as expected.
> I have also attached before/after PCAPs and the simple patch I have used to solve this.  The problem is present, and the patch works, in both 11.5.0, and the head of branches/11 (SVN-branch-11-r397758).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira