[asterisk-bugs] [JIRA] (ASTERISK-22410) Change "Error isn't a PubSub error ..." error log to a debug log

[abelbeck (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209703#comment-209703 ] 

abelbeck commented on ASTERISK-22410:
-------------------------------------

The focus of this 'issue' is to point out that in general XMPP servers may return superfluous non-pubsub errors for any number of reasons.  I'm suggesting this sort of error should not be logged as an Asterisk error, but rather as a level 1 debug error.

Case in point, while using Prosody 0.9.0 the number of error messages generated are quite misleading.

Rusty, to further elaborate on the segfault issue…

With res_xmpp, both Prosody 0.8.2 and 0.9.0 work fine.

With res_jabber, Prosody 0.8.2 causes it to segfault, prosody 0.9.0 works fine.

Since Matthew was not clear why 0.9.0 fixed res_jabber, I disabled TLS to see what is going on, attached is a brief synopsis.

Attached file: res_jabber-prosody-0.8.2-vs-0.9.0.txt

                
> Change "Error isn't a PubSub error ..." error log to a debug log
> ----------------------------------------------------------------
>
>                 Key: ASTERISK-22410
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22410
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_jabber, Resources/res_xmpp
>    Affects Versions: 1.8.23.0, 11.5.0
>         Environment: AstLinux 1.1.x
>            Reporter: abelbeck
>            Assignee: abelbeck
>            Severity: Minor
>         Attachments: asterisk-11-res_xmpp-log-nonpubsub-error-to-debug.patch, asterisk-1.8-res_jabber-log-nonpubsub-error-to-debug.patch, res_jabber-prosody-0.8.2-vs-0.9.0.txt
>
>
> The good news, Prosody 0.9.0 now works with Asterisk 1.8 which requires the 'from' attribute in the XMPP: iq id='disco' type='get' ... , or else Asterisk 1.8 segfaults.
> More good news, Prosody 0.9.0 supports pubsub.
> The bad news, when enabling distributed device state via XMPP/PubSub I'm seeing a lot of "Error isn't a PubSub error, why are we here?" error logs.
> According to Matthew Wild, Prosody developer, he gives this synopsis:
> -- SERVER: Error: node with this name already exists
> <iq id='aaaah' type='error' to='asterisk1 at pbx.example.tld/asterisk' from='pubsub.pbx.example.tld'><error type='cancel'><conflict xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/></error></iq>
> -- SERVER: Stanza not handled (Prosody doesn't currently support modification of ACLs over XMPP)
> <iq id='aaaai' type='error' to='asterisk1 at pbx.example.tld/asterisk' from='pubsub.pbx.example.tld'><error type='cancel'><service-unavailable xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/></error></iq>
> The ACL issue can be worked around by defining "admins" for Prosody's pubsub configuration and the pre-existing node error seems to be safely ignored.
> All in all, distributed device state seems to work with Prosody 0.9.0 and Asterisk 1.8/11 with limited testing, though the many error logs are annoying.
> Suggested is changing the non-pubsub error log to a debug log.  Patches to follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira