[asterisk-bugs] [JIRA] (ASTERISK-22248) [patch] test_sip_rtpqos corrupts dialogs container

[Mark Michelson (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209370#comment-209370 ] 

Mark Michelson commented on ASTERISK-22248:
-------------------------------------------

It appears that both the unlink and the unref are required. The unlink will remove the dialog from the container, but without the additional unref, the dialog itself will be leaked. I'll go ahead and make the necessary change and get the fix committed.
                
> [patch] test_sip_rtpqos corrupts dialogs container
> --------------------------------------------------
>
>                 Key: ASTERISK-22248
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22248
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: SVN, 1.8.24.0, 11.6.0
>            Reporter: Corey Farrell
>         Attachments: backtrace-test_sip_rtpqos.txt, test_sip_rtpqos.patch
>
>
> test_sip_rtpqos unref's the dialog when it should be unlinked.  This free's the dialog while leaving it listed in the container.  In my tests this causes a segfault when unload_module() tries to free the dialog again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira