[asterisk-bugs] [JIRA] (ASTERISK-22310) Improve error message 'Not a wav file '... in format_wav.c; current message is ambiguous

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209326#comment-209326 ] 

Rusty Newton commented on ASTERISK-22310:
-----------------------------------------

Normally we would require a patch, but it's trivial in this case. Thanks for the report. I agree that this message should be more specific.
                
> Improve error message 'Not a wav file '... in format_wav.c; current message is ambiguous
> ----------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-22310
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22310
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Documentation, Formats/format_wav
>    Affects Versions: 11.5.0
>         Environment: All
>            Reporter: Jim Credland
>            Severity: Minor
>
> The following error message lies.  Many things are WAV files which do not contain 1 in the format field.  
> if (ltohs(format) != 1) {
>  ast_log(LOG_WARNING, "Not a wav file %d\n", ltohs(format));
> Given how unusual the .WAV vs. .wav distinction is I'd go for:  "Not a supported wav file format (%d). Only PCM encoded versions are supported with a lower-case '.wav' extension."
> Which would be helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira