[asterisk-bugs] [JIRA] (ASTERISK-22294) format_g729 - better handling of CNG

[Jaco Kroon (JIRA)]

Jaco Kroon created ASTERISK-22294:
-------------------------------------

             Summary: format_g729 - better handling of CNG
                 Key: ASTERISK-22294
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22294
             Project: Asterisk
          Issue Type: Improvement
      Security Level: None
          Components: Formats/format_g729
    Affects Versions: 11.5.0
         Environment: asterisk 11.5.0
            Reporter: Jaco Kroon
            Severity: Trivial


In spite of asterisk passing all possible paramaters to kill VAD (annexb) some endpoints are hard-coded to send it, or simply ignore these settings.  I've got two examples, the one is a Yealink phone with "silence suppression" switched on, the other is an upstream peer for one of my clients.  To aggravate the issue they combine CNG with payload, and insist on a ptime=60, so I've seen 10*n+2 byte packets.  The assumption here is that the first 50 bytes is payload followed by 2 bytes CNG parameter data.

I've written a patch that will in these cases take whatever payload it can and write it to the stream and silently (after generating a WARNING to the logs for each affected stream - I'd like to add the actual channel name to the warning but don't see an easy way) discard the CNG data.  This results in 10-byte all-zero blocks, which I'll deal with externally.  This results in a 100Hz hum-like noise when listening to the stream again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira