[asterisk-bugs] [JIRA] (ASTERISK-22071) chan_sip doesn't respect Via ..completely

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-22071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=208451#comment-208451 ] 

Michael L. Young edited comment on ASTERISK-22071 at 8/1/13 12:40 PM:
----------------------------------------------------------------------

Alex,

Sorry that I haven't been able to chime in.  Mark tracked down where I was looking as well before being taken away to work on some other projects which took me away from here.

I agree with Walter... more than likely, that is the culprit.  After looking at this, I see my thinking was flawed at the time.  Actually, I recall looking at this line briefly before uploading the patch to the issue that Walter pointed out.  It was one of those lines added while debugging and tracking things down and in the end I left in there for some reason thinking it was an optimization.  There is no harm done by reversing that one change to find out if that is it.

Since Mark states his patch might break interoperability with some clients, can you please test reversing that change Walter helped to point out with the following patch I will be attaching?  If you could report back, then Mark can decide which direction to go in regards to which fix should go into the code. I have a feeling that reversing that change will be the safest way to go.

If we find this is the culprit, this fix will need to be applied to 1.8 as well.

[^asterisk-22071-store-recvd-address.diff]
                
      was (Author: elguero):
    Alex,

Sorry that I haven't been able to chime in.  Mark tracked down where I was looking as well before being taken away to work on some other projects which took me away from here.

I agree with Walter... more than likely, that is the culprit.  After looking at this, I see my thinking was flawed at the time.  Actually, I recall looking at this line briefly before uploading the patch to the issue that Walter pointed out.  It was one of those lines added while debugging and tracking things down and in the end I left in there for some reason thinking it was an optimization.  There is no harm done by reversing that one change to find out if that is it.

Since Mark states his patch might break interoperability with some clients, can you please test reversing that change Walter helped to point out with the following patch I will be attaching?  If you could report back, then Mark can decide which direction to go in regards to which fix should go into the code. I have a feeling that reversing that change will be the safest way to go.

If we find this is the culprit, this fix will need to be applied to 1.8 as well.
                  
> chan_sip doesn't respect Via ..completely
> -----------------------------------------
>
>                 Key: ASTERISK-22071
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-22071
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.4.0
>         Environment: CentOS 6.4
>            Reporter: Alex Zarubin
>            Assignee: Mark Michelson
>         Attachments: asterisk-11.{2.1,4.0}-channels-chan_sip.c.diff, ASTERISK-22071.patch, asterisk-22071-store-recvd-address.diff, AsteriskJira22071.txt, issue_22071_0715_11.5.0-rc2, issue_22071_gen, issue_22071_log11.2.1, issue_22071_sipsettings, sip.conf, sipsettings
>
>
> The same exact sip call works in 11.2.1 and fails in 11.4. Outbound call is established normally via proxy. BYE comes from proxy with <proxy ip/port> in first Via header. 11.4 adds received=<carrier ip/port> and sends OK there. BYE is repeated several times.
> Will try to attach sip.conf and trace once this jira issue is created. Thank you.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira