[asterisk-bugs] [JIRA] (ASTERISK-21677) SIP Notify / BLF Stop Working

[Alec Davis (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=205931#comment-205931 ] 

Alec Davis edited comment on ASTERISK-21677 at 4/26/13 5:13 PM:
----------------------------------------------------------------

updated patch review2475.diff2.txt as from reviewboard.

This fix, although correct by the RFC6665, is going to break a lot of installs, as sip.conf:maxexpiry default is 3600.

For 1.8 and 11 we need to fix the logic error, in retrans_pkt() I'd propose to clear the pvt->pendinginvite and clear the SIP_PAGE_STATECHANGEQUEUE flag after the retries fail. This will allow further NOTIFYs to happen. But not remove the subscription.

For trunk, remove the subscription, and let the client re-subscribe.

edit: ========================

What am I thinking, regarding breaking a lot of installs?
1.8 and 11 already are broken after a Notify fails.
The only fix today is rebooting the client, which will get a new subscription, the old subscription will expire in it's own time.

So the proposed fix review2475.diff2.txt for 1.8 to trunk is to remove the subscription when a State NOTIFY fails, and let the client re-subscribe after it's own expiry timer fires.


                
      was (Author: alecdavis):
    updated patch review2475.diff2.txt as from reviewboard.

This fix, although correct by the RFC6665, is going to break a lot of installs, as sip.conf:maxexpiry default is 3600.

For 1.8 and 11 we need to fix the logic error, in retrans_pkt() I'd propose to clear the pvt->pendinginvite and clear the SIP_PAGE_STATECHANGEQUEUE flag after the retries fail. This will allow further NOTIFYs to happen. But not remove the subscription.

For trunk, remove the subscription, and let the client re-subsribe.
                  
> SIP Notify / BLF Stop Working
> -----------------------------
>
>                 Key: ASTERISK-21677
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21677
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.3.0
>         Environment: Centos 5.6, Quad Core Intel Xeon @ 3.0GHZ, 4GB RAM
>            Reporter: Dan Martens
>            Assignee: Dan Martens
>         Attachments: bug21677.diff.txt, review2475.diff2.txt, review2475.diff.txt
>
>
> Hello, 
> We have noticed that since we upgraded to Asterisk 11, the BLF lamps on phones (multiple makes and models) stop working from time to time.  To get them to work again, we have to bring the device offline and back online again.
> When this happens, we start to see a lot of "queued" messages in the logs regarding the extension that is not working.  For example:
> Extension Changed 100[witgoffice-local] new state Ringing for Notify User witg_116 (queued)
> Once a device is listed as "queued", it will never be dequeued unless you make it go offline.  It gets stuck in this state.
> SIP network traces show that once the device goes into queued state, Asterisk will no longer send any NOTIFY messages.  It only sends them when it is in non-queued state.  
> A brief look at the code, shows that the flag which gets reset to allow these notifications to get through only gets reset in a single branch of code:
> chan_sip.c at 22939 in handle_response_notify 
> ast_clear_flag(&p->flags[1], SIP_PAGE2_STATECHANGEQUEUE);
> This will only occur when a device sends back a 200 OK request to a previous NOTIFY message.  If this response never comes back (ie. packet loss etc.), then the flag gets stuck in this state forever.
> I would propose that a fix to this would be to reset the flag:
> ast_clear_flag(&p->flags[1], SIP_PAGE2_STATECHANGEQUEUE);
> during either a SUBSCRIBE request or REGISTER request.  That way, if the flag is stuck, it will get reset in a short amount of time when the device performs its next registration routine.  That is, unless I am completely wrong or there is a better way of doing things.
> Your help is greatly appreciated.
> Thanks,

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira