[asterisk-bugs] [JIRA] (ASTERISK-21677) SIP Notify / BLF Stop Working

[Rusty Newton (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=205786#comment-205786 ] 

Rusty Newton edited comment on ASTERISK-21677 at 4/24/13 5:30 PM:
------------------------------------------------------------------

When filing an issue the guidelines were listed: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines (we need to make it a required field)

You can always submit a patch. Post it this issue following the guidelines found in the article above.  Submitting your own patch is typically going to help things progress quicker, but of course it could always end up that the patch is not appropriate. 

It would be good to also help others verify this bug. Please post an Asterisk log with VERBOSE and DEBUG messages at level 5 or above, with SIP debug enabled, plus a PCAP of the SIP traffic happening at the same time. That should be a good example of the issue happening. Then it's probably a good idea to go ahead and provide all relevant .conf files that would allow someone to reproduce the issue. Please attach all debug and configuration to the issue as separate .txt files for ease of use. Hit "Send Back" to change the state of the ticket back.
                
      was (Author: rnewton):
    When filing an issue the guidelines were listed: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines (we need to make it a required field)

You can always submit a patch. Post it this issue following the guidelines found in the article above.  Submitting your own patch is typically going to help things progress quicker, but of course it could always end up that the patch is not appropriate. 

It would be good to also help others verify this bug. Please post an Asterisk log with VERBOSE and DEBUG messages at level 5 or above, with SIP debug enabled, plus a PCAP of the SIP traffic happening at the same time. That should be a good example of the issue happening. Then it's probably a good idea to go ahead and provide all relevant configs that would allow someone to reproduce the issue. 
                  
> SIP Notify / BLF Stop Working
> -----------------------------
>
>                 Key: ASTERISK-21677
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21677
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.3.0
>         Environment: Centos 5.6, Quad Core Intel Xeon @ 3.0GHZ, 4GB RAM
>            Reporter: Dan Martens
>
> Hello, 
> We have noticed that since we upgraded to Asterisk 11, the BLF lamps on phones (multiple makes and models) stop working from time to time.  To get them to work again, we have to bring the device offline and back online again.
> When this happens, we start to see a lot of "queued" messages in the logs regarding the extension that is not working.  For example:
> Extension Changed 100[witgoffice-local] new state Ringing for Notify User witg_116 (queued)
> Once a device is listed as "queued", it will never be dequeued unless you make it go offline.  It gets stuck in this state.
> SIP network traces show that once the device goes into queued state, Asterisk will no longer send any NOTIFY messages.  It only sends them when it is in non-queued state.  
> A brief look at the code, shows that the flag which gets reset to allow these notifications to get through only gets reset in a single branch of code:
> chan_sip.c at 22939 in handle_response_notify 
> ast_clear_flag(&p->flags[1], SIP_PAGE2_STATECHANGEQUEUE);
> This will only occur when a device sends back a 200 OK request to a previous NOTIFY message.  If this response never comes back (ie. packet loss etc.), then the flag gets stuck in this state forever.
> I would propose that a fix to this would be to reset the flag:
> ast_clear_flag(&p->flags[1], SIP_PAGE2_STATECHANGEQUEUE);
> during either a SUBSCRIBE request or REGISTER request.  That way, if the flag is stuck, it will get reset in a short amount of time when the device performs its next registration routine.  That is, unless I am completely wrong or there is a better way of doing things.
> Your help is greatly appreciated.
> Thanks,

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira