[asterisk-bugs] [JIRA] (ASTERISK-21677) SIP Notify / BLF Stop Working

[Dan Martens (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=205783#comment-205783 ] 

Dan Martens commented on ASTERISK-21677:
----------------------------------------

Hi Alec,

I was wondering why this flag existed in the first place, now I know.

The way I read the RFC you posted would be for each subscription.  If it were to be per device, updates to phones with many subscriptions (ie. reception consoles) could take a very long time and would not be acceptable to the user.

I like your idea of a timer on the notify messages.  It makes more sense to implement this type of mechanism instead of my suggestion (which is basically just a quick hack to get things working).  In my opinion, the flag method for implementing this RFC as it currently stands is a poor way of doing things if it is just meant as a rate limiting feature.

I'm new to posting for asterisk, so not sure where this process goes from here.  Is it up to me to submit a patch or is there someone who looks after chan_sip that has to verify the bug and approve all proposed changes?

Thanks.
                
> SIP Notify / BLF Stop Working
> -----------------------------
>
>                 Key: ASTERISK-21677
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21677
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.3.0
>         Environment: Centos 5.6, Quad Core Intel Xeon @ 3.0GHZ, 4GB RAM
>            Reporter: Dan Martens
>
> Hello, 
> We have noticed that since we upgraded to Asterisk 11, the BLF lamps on phones (multiple makes and models) stop working from time to time.  To get them to work again, we have to bring the device offline and back online again.
> When this happens, we start to see a lot of "queued" messages in the logs regarding the extension that is not working.  For example:
> Extension Changed 100[witgoffice-local] new state Ringing for Notify User witg_116 (queued)
> Once a device is listed as "queued", it will never be dequeued unless you make it go offline.  It gets stuck in this state.
> SIP network traces show that once the device goes into queued state, Asterisk will no longer send any NOTIFY messages.  It only sends them when it is in non-queued state.  
> A brief look at the code, shows that the flag which gets reset to allow these notifications to get through only gets reset in a single branch of code:
> chan_sip.c at 22939 in handle_response_notify 
> ast_clear_flag(&p->flags[1], SIP_PAGE2_STATECHANGEQUEUE);
> This will only occur when a device sends back a 200 OK request to a previous NOTIFY message.  If this response never comes back (ie. packet loss etc.), then the flag gets stuck in this state forever.
> I would propose that a fix to this would be to reset the flag:
> ast_clear_flag(&p->flags[1], SIP_PAGE2_STATECHANGEQUEUE);
> during either a SUBSCRIBE request or REGISTER request.  That way, if the flag is stuck, it will get reset in a short amount of time when the device performs its next registration routine.  That is, unless I am completely wrong or there is a better way of doing things.
> Your help is greatly appreciated.
> Thanks,

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira