[asterisk-bugs] [JIRA] (ASTERISK-21466) [patch] [crash] "sip show peers" crashes Asterisk with ~3500 registered peers

[Richard Mudgett (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=205377#comment-205377 ] 

Richard Mudgett commented on ASTERISK-21466:
--------------------------------------------

The patch does not check the return value of ast_strdup() for NULL.
                
> [patch] [crash] "sip show peers" crashes Asterisk with ~3500 registered peers
> -----------------------------------------------------------------------------
>
>                 Key: ASTERISK-21466
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21466
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 11.3.0
>         Environment: Linux 32 bits
>            Reporter: Guillaume Knispel
>            Severity: Critical
>         Attachments: fix_sip_show_peers_stack_overflow_asterisk_11.3.0.patch
>
>
> When there are lots of registered sip peers (around 3500, but it could depend on the IP adresses), the "sip show peers" CLI command immediately crashes Asterisk by stack overflow. (Trying to get the same informations through AMI very probably leads to the same crash.)
> This is caused by the use of ast_strdupa() in the main loop of _sip_show_peers()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira