[asterisk-bugs] [JIRA] (ASTERISK-21429) Distributed Device State using XMPP not working since 11-r378321

[Alec Davis (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-21429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=205298#comment-205298 ] 

Alec Davis commented on ASTERISK-21429:
---------------------------------------

attached bug21429.diff.txt

This fixes the scenario when an older system doesn't send the IE cachable=1 in the XMPP message, to a newer system that expects to see it.

If the IE 'cachable' isn't present we need to default to AST_DEVSTATE_CACHABLE.
Assigning the cachable variable directly from ast_event_get_ie_uint is wrong, if the IE 'cachable' isn't found ast_event_get_ie_uint() will return 0, 0 = AST_DEVSTATE_NOT_CACHABLE

We need to read the 'cachable' IE into a string first, allowing us to check that it exists, if it doesn't exist then default to cachable=AST_DEVSTATE_CACHABLE.
If the 'cachable' IE does exist, then convert to a uint, validate value and go with it.
                
> Distributed Device State using XMPP not working since 11-r378321
> ----------------------------------------------------------------
>
>                 Key: ASTERISK-21429
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-21429
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>         Environment: SiteA SVN-branch-11-r376441
> SiteB SVN-branch-11-r378321
>            Reporter: Alec Davis
>         Attachments: bug21429.diff.txt
>
>
> Prior to the cachable devicestate changes from https://issues.asterisk.org/jira/browse/ASTERISK-20175, both sites worked fine.
> Site B is the site having issues, it doesn't update it's hints, and the phones that subscribe to the hint don't update there BLF.
> Reverting back to asterisk-11-r378287 at SiteB and it works again.
> SiteA is running a version without the devicestate cachable changes, thus is not sending the new IE cachable=1, but from what I can tell the default is to assume cachable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.asterisk.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira