[asterisk-bugs] [JIRA] Issue Comment Edited: (ASTERISK-20457) GSM encoding is not thread safe

[Richard Miller (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197372#comment-197372 ] 

Richard Miller edited comment on ASTERISK-20457 at 9/21/12 5:17 AM:
--------------------------------------------------------------------

You can either use the patch I submitted which is simpler, or get the updated source from the author of libgsm at http://www.quut.com/gsm/gsm-1.0.13.tar.gz

      was (Author: ulogic):
    You can either use this patch which is simpler, or get the updated source from the author of libgsm at http://www.quut.com/gsm/gsm-1.0.13.tar.gz
  
> GSM encoding is not thread safe
> -------------------------------
>
>                 Key: ASTERISK-20457
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20457
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Codecs/codec_gsm
>    Affects Versions: 1.8.16.0, 10.8.0, 11.0.0-beta2
>            Reporter: Richard Miller
>         Attachments: code.diff
>
>
> The file codecs/gsm/src/code.c uses a static variable "e" that it is passing down into a lower level function.  The original author in patch level 12 moved it into the gsm_state structure, but that really isn't necessary.  All that needs to be done is to make it a temporary local variable by removing the "static" qualifier.  The bug does not affect decoding, only encoding.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira