[asterisk-bugs] [JIRA] Issue Comment Edited: (ASTERISK-20109) get_ast_cmd doesn't differentiate between failure and empty list return

[Jonathan Rose (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197236#comment-197236 ] 

Jonathan Rose edited comment on ASTERISK-20109 at 9/18/12 10:40 AM:
--------------------------------------------------------------------

The third segment of this patch has some fundamental wrongness too it making it completely broken. I think the patch is perfectly salvageable though.

the following condition:
  (!hungup && !(res=get_agi_cmd(...))

implies !res, so the only way to enter this while loop is in the way that causes the if statement to occur, which means at a bare minimum that the rest of this loop will never run.

Is what you meant to put there if (!cmd) instead maybe?