[asterisk-bugs] [JIRA] Created: (ASTERISK-20435) app_voicemail deletes the wrong greeting if both an unavailable and a temporary greeting is available and imap greetings are used

[fhackenberger (JIRA)]

app_voicemail deletes the wrong greeting if both an unavailable and a temporary greeting is available and imap greetings are used
---------------------------------------------------------------------------------------------------------------------------------

                 Key: ASTERISK-20435
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20435
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Applications/app_voicemail/IMAP
    Affects Versions: 1.8.16.0
            Reporter: fhackenberger
         Attachments: msgnum_negative.patch

Set up voicemail with imap and imapgreetings=yes in voicemail.conf

Dial into VoiceMailMain and do the following:
* Record an unavail greeting
* Hangup
* Record a temp greeting
* Hangup
* Delete a temp greeting (BUG: it deletes the unavailable greeting)

The bug seems to be that vm_imap_delete uses the msgnum parameter as an index into vms->msgArray even if it is negative, which is certainly wrong. I assume (talked to mjordan on IRC) that passing -1 as the msgnum indicates that the current message should be deleted (vms->curmsg). The attached patch fixes that. It issue is present in 1.6 (where I debugged the issue) as well as the current 1.8 branch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira