[asterisk-bugs] [JIRA] Commented: (ASTERISK-20366) Build errors on OpenSolaris

[Shaun Ruffell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196795#comment-196795 ] 

Shaun Ruffell commented on ASTERISK-20366:
------------------------------------------

A note in case the eventual committer wants to test / review / and commit all the patches (in this case two so far) together as a unit.

{code}
git svn clone -r HEAD http://svn.asterisk.org/svn/asterisk/branches/11 asterisk-11-to-commit
cd asterisk-11-to-commit/
git svn rebase
wget "https://issues.asterisk.org/jira/secure/attachment/44536/0001-RFC-pjproject-Fix-for-Solaris-builds.-Do-not-undef-s.patch" -O - | git am
wget "https://issues.asterisk.org/jira/secure/attachment/44537/0002-main-acl.c-Trivial.-best_score-should-be-defined-for.patch" -O - | git am
# Add menuselect temporarily so that you can build / test / do whatever you need to do to convince yourself the patches are good
svn export http://svn.asterisk.org/svn/menuselect/trunk menuselect
git add menuselect/
git commit -m "DELETE: menuselect"
./configure && make
## Now you can rebase the entire patch set to add any notes to the commit messages and delete menuselect before commiting
git rebase -i git-svn
{code}

When you run rebase you'll see something like the following:

{noformat}
pick 8fb011a pjproject: Fix for Solaris builds. Do not undef s_addr.
pick e11acfd main/acl.c: Trivial. 'best_score' should be defined for all architectures.
pick c928497 DELETE: adding menuselect
  
# Rebase fb21af1..c928497 onto fb21af1
#
# Commands:
#  p, pick = use commit
#  r, reword = use commit, but edit the commit message
#  e, edit = use commit, but stop for amending
#  s, squash = use commit, but meld into previous commit
#  f, fixup = like "squash", but discard this commit's log message
#  x, exec = run command (the rest of the line) using shell
#
# These lines can be re-ordered; they are executed from top to bottom.
#
# If you remove a line here THAT COMMIT WILL BE LOST.
# However, if you remove everything, the rebase will be aborted.
#
# Note that empty commits are commented out
{noformat}

Which you should just change to the following in order to reword the two real commits and drop menuselect (so you don't commit it to the 11-branch since it's an external) before committing to subversion:

{noformat}
r 3bb5a77 pjproject: Fix for Solaris builds. Do not undef s_addr.
r 921eaf4 main/acl.c: Trivial. 'best_score' should be defined for all architectures.
{noformat}

Only after everything looks good do you need to commit with:

{noformat}
git svn dcommit
{noformat}

> Build errors on OpenSolaris
> ---------------------------
>
>                 Key: ASTERISK-20366
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20366
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 11.0.0-beta1
>         Environment: OpenSolaris
>            Reporter: Ben Klang
>         Attachments: 0001-RFC-pjproject-Fix-for-Solaris-builds.-Do-not-undef-s.patch, 0002-main-acl.c-Trivial.-best_score-should-be-defined-for.patch
>
>
> While building Asterisk 11 on OpenSolaris I get this error:
> {noformat}
>    [CC] res_rtp_asterisk.c -> res_rtp_asterisk.o
> In file included from /export/home/admin/asterisk-11-svn/include/asterisk/stun.h:29,
>                  from res_rtp_asterisk.c:51:
> /export/home/admin/asterisk-11-svn/include/asterisk/network.h: In function `inaddrcmp':
> /export/home/admin/asterisk-11-svn/include/asterisk/network.h:92: error: structure has no member named `s_addr'
> /export/home/admin/asterisk-11-svn/include/asterisk/network.h:92: error: structure has no member named `s_addr'
> res_rtp_asterisk.c: In function `ast_rtp_on_ice_tx_pkt':
> res_rtp_asterisk.c:706: warning: dereferencing type-punned pointer will break strict-aliasing rules
> res_rtp_asterisk.c:710: warning: dereferencing type-punned pointer will break strict-aliasing rules
> res_rtp_asterisk.c: In function `rtp_add_candidates_to_ice':
> res_rtp_asterisk.c:1085: error: structure has no member named `s_addr'
> make[2]: *** [res_rtp_asterisk.o] Error 1
> make[1]: *** [res] Error 2
> make[1]: Leaving directory `/export/home/admin/asterisk-11-svn'
> gmake: *** [_cleantest_all] Error 2
> {noformat}
> I'm marking as a regression because Asterisk 10 builds and runs fine on this platform.  Please correct me if this should not be a regression.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira