[asterisk-bugs] [JIRA] Issue Comment Edited: (ASTERISK-20366) Build errors on OpenSolaris

[Ben Klang (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196748#comment-196748 ] 

Ben Klang edited comment on ASTERISK-20366 at 9/7/12 9:51 AM:
--------------------------------------------------------------

Thanks for the acknowledgement Rusty.  The structure definitions are in the gist link above, but I'll paste them here as well:

<pre>
/*
 * IPv4 Socket address.
 */
struct sockaddr_in {
        sa_family_t     sin_family;
        in_port_t       sin_port;
        struct  in_addr sin_addr;
#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
        char            sin_zero[8];
#else
        unsigned char   sin_zero[8];
#endif /* !defined(_XPG4_2) || defined(__EXTENSIONS__) */
};

struct in_addr {
        union {
                struct { uint8_t s_b1, s_b2, s_b3, s_b4; } _S_un_b;
                struct { uint16_t s_w1, s_w2; } _S_un_w;
#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
                uint32_t _S_addr;
#else
                in_addr_t _S_addr;
#endif /* !defined(_XPG4_2) || defined(__EXTENSIONS__) */
        } _S_un;
#define s_addr  _S_un._S_addr           /* should be used for all code */
#define s_host  _S_un._S_un_b.s_b2      /* OBSOLETE: host on imp */
#define s_net   _S_un._S_un_b.s_b1      /* OBSOLETE: network */
#define s_imp   _S_un._S_un_w.s_w2      /* OBSOLETE: imp */
#define s_impno _S_un._S_un_b.s_b4      /* OBSOLETE: imp # */
#define s_lh    _S_un._S_un_b.s_b3      /* OBSOLETE: logical host */
};
</pre>

      was (Author: bklang):
    Thanks for the acknowledgement Rusty.  The structure definitions are in the gist link above, but I'll paste them here as well:

/*
 * IPv4 Socket address.
 */
struct sockaddr_in {
        sa_family_t     sin_family;
        in_port_t       sin_port;
        struct  in_addr sin_addr;
#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
        char            sin_zero[8];
#else
        unsigned char   sin_zero[8];
#endif /* !defined(_XPG4_2) || defined(__EXTENSIONS__) */
};

struct in_addr {
        union {
                struct { uint8_t s_b1, s_b2, s_b3, s_b4; } _S_un_b;
                struct { uint16_t s_w1, s_w2; } _S_un_w;
#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
                uint32_t _S_addr;
#else
                in_addr_t _S_addr;
#endif /* !defined(_XPG4_2) || defined(__EXTENSIONS__) */
        } _S_un;
#define s_addr  _S_un._S_addr           /* should be used for all code */
#define s_host  _S_un._S_un_b.s_b2      /* OBSOLETE: host on imp */
#define s_net   _S_un._S_un_b.s_b1      /* OBSOLETE: network */
#define s_imp   _S_un._S_un_w.s_w2      /* OBSOLETE: imp */
#define s_impno _S_un._S_un_b.s_b4      /* OBSOLETE: imp # */
#define s_lh    _S_un._S_un_b.s_b3      /* OBSOLETE: logical host */
};

  
> Build errors on OpenSolaris
> ---------------------------
>
>                 Key: ASTERISK-20366
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20366
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 11.0.0-beta1
>         Environment: OpenSolaris
>            Reporter: Ben Klang
>
> While building Asterisk 11 on OpenSolaris I get this error:
>    [CC] res_rtp_asterisk.c -> res_rtp_asterisk.o
> In file included from /export/home/admin/asterisk-11-svn/include/asterisk/stun.h:29,
>                  from res_rtp_asterisk.c:51:
> /export/home/admin/asterisk-11-svn/include/asterisk/network.h: In function `inaddrcmp':
> /export/home/admin/asterisk-11-svn/include/asterisk/network.h:92: error: structure has no member named `s_addr'
> /export/home/admin/asterisk-11-svn/include/asterisk/network.h:92: error: structure has no member named `s_addr'
> res_rtp_asterisk.c: In function `ast_rtp_on_ice_tx_pkt':
> res_rtp_asterisk.c:706: warning: dereferencing type-punned pointer will break strict-aliasing rules
> res_rtp_asterisk.c:710: warning: dereferencing type-punned pointer will break strict-aliasing rules
> res_rtp_asterisk.c: In function `rtp_add_candidates_to_ice':
> res_rtp_asterisk.c:1085: error: structure has no member named `s_addr'
> make[2]: *** [res_rtp_asterisk.o] Error 1
> make[1]: *** [res] Error 2
> make[1]: Leaving directory `/export/home/admin/asterisk-11-svn'
> gmake: *** [_cleantest_all] Error 2
> I'm marking as a regression because Asterisk 10 builds and runs fine on this platform.  Please correct me if this should not be a regression.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira