[asterisk-bugs] [JIRA] Commented: (ASTERISK-20380) Bad ao2_unlock call in app_queue's try_calling

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196739#comment-196739 ] 

Matt Jordan commented on ASTERISK-20380:
----------------------------------------

Pretty sure this is going to be the case in 1.8 and 10 as well.

> Bad ao2_unlock call in app_queue's try_calling
> ----------------------------------------------
>
>                 Key: ASTERISK-20380
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20380
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_queue
>    Affects Versions: 11.0.0-beta1
>            Reporter: Jeremy Pepper
>            Severity: Minor
>         Attachments: fix-local-channel-locking.patch
>
>
> It looks like there's a typo in try_calling:
> {code}
> 			if (!(dialed_interfaces = ast_calloc(1, sizeof(*dialed_interfaces)))) {
> 				callattempt_free(tmp);
> 				ao2_ref(cur, -1);
> 				ao2_iterator_destroy(&memi);
> 				ao2_unlock(&qe->parent);
> 				goto out;
> 			}
> {code}
> Surely that should be spelled {{ao2_unlock(qe->parent);}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira