[asterisk-bugs] [JIRA] Commented: (ASTERISK-20362) res_asterisk_rtp: Fix build error when using parallel make

[Timo Teräs (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196651#comment-196651 ] 

Timo Teräs commented on ASTERISK-20362:
---------------------------------------

I have no strong opinion on the solution as long as the bug gets fixed :)

That said, thinking more, dependency on $(PJ_LIB_FILES) is good to have so we recompile things properly if something changes in the pjproject. I kinda liked the stamp to avoid calling the submake, but to validate that pjproject is up-to-date it's probably better to do it as your patch does.

So I think I'd be happier with your version than mine. Thanks.

> res_asterisk_rtp: Fix build error when using parallel make
> ----------------------------------------------------------
>
>                 Key: ASTERISK-20362
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20362
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>            Reporter: Shaun Ruffell
>            Severity: Minor
>         Attachments: 0001-res_asterisk_rtp-Fix-build-error-when-using-parallel.patch, 0001-res_asterisk_rtp-Fix-build-error-when-using-parallel.patch, ASTERISK-20362.patch
>
>
> {noformat}
>    Fixes a build regression introduced in r369517 "Add support for ICE/STUN/TURN                                    
>     in res_rtp_asterisk and chan_sip." [1].                                                         
>                                                                                                               
>     [1] http://svnview.digium.com/svn/asterisk?view=revision&revision=369517
>                                                                                                                 
>     When compiling asterisk in parallel like:                                 
>         $ make -j 10                                                                                                   
>                                                                                     
>     It's possible to get errors like the following:                                   
>                                                                                           
>         .pjlib-util-test-x86_64-unknown-linux-gnu.depend:120: *** missing separator.  Stop.                 
>         make[4]: *** [depend] Error 2                                                                        
>         make[3]: *** [dep] Error 1                                                                      
>         make[2]: *** [/home/sruffell/asterisk-working/res/pjproject/pjnath/lib/libpjnath-x86_64-unknown-linux-gnu.a] Error 2
>         make[3]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.                           
>                                                                                     
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira