[asterisk-bugs] [JIRA] Commented: (ASTERISK-20194) SRTP: after hold action no audio on holded peer.

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196562#comment-196562 ] 

Matt Jordan commented on ASTERISK-20194:
----------------------------------------

So, I did a lot of testing with a snom 320 and an Aastra phone that I was able to procure.  Unfortunately, I still wasn't able to reproduce your issue - I tried having a conversation for 10-15 min, put either UA on hold, took them off hold, etc. - and never had one way audio that duplicated your SIP traces and/or DEBUG logs.

That being said, in my testing, I did discover some other issues with SRTP that made it difficult for either the Aastra or the snom 320 to work properly.  This included some negotiation issues with the snom 320, where we wouldn't process a request that wasn't SAVP, and where we responded with a policy suite that was different than the one we had applied for the UA.

The attached patch includes those changes, as well as another.

One of the things that was changed in recent versions was the ability to have Asterisk actually handle the keys changing after a hold or transfer; however, the mechanism employed to do that applied to any re-INVITE, regardless of whether the key changed.  The attached patch caches the remote key value and only resets the crypto policy if the key has changed.

Taken together, this may - or may not - resolve the problem you're seeing.  If you could test it out, however, I'd appreciate it.

> SRTP: after hold action no audio on holded peer.
> ------------------------------------------------
>
>                 Key: ASTERISK-20194
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20194
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_srtp
>    Affects Versions: 1.8.13.1, 1.8.14.0, 1.8.15.0
>         Environment: Linux Centos 5.7
>            Reporter: Nicolò Mazzon
>            Assignee: Matt Jordan
>            Severity: Critical
>         Attachments: config.txt, dump_srtp.zip.001, dump_srtp.zip.002, dump_srtp.zip.003, file.zip.001, file.zip.002, file.zip.003, file.zip.004, file.zip.005, full.log, full.log, full.tmp, sip_trace.pcap, siptrace.pcap, srtp_patches.diff
>
>
> On a call with SRTP after peer hold another and unhold, the holded peer does not hear anything, the holder peer continue to hear audio call. This happens after 10-15 minutes of conversation. 
> We verified this every time with version from version 1.8.13. Instead 1.8.12 works ok.
> We made many tests with different phone models (SNOM, Polycom, Yealink) and issue occured every time.
> We attach our configuration and log. Log level is verbose = 12 and debug = 12.
> This is the scenario:
> ||action||hour||
> |2209 call 2210| 10.43|
> |2210 answer||                     
> |2210 hold|11.00|
> |2210 unhold|11.01|
> |2209 no audio||
> |2209 hangup up|11.02|

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira