[asterisk-bugs] [JIRA] (ASTERISK-20599) A Module to Submit CDR via Curl to a webservice end point

[Matt Jordan (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-20599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Jordan updated ASTERISK-20599:
-----------------------------------

    Assignee: Rusty Newton  (was: Alex)
      Status: Open  (was: Waiting for Feedback)

So, before readying the patch for Review Board, you should make sure that the patch conforms to the coding guidelines on the Asterisk wiki:


https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines

Two things I noticed in the patch, but there may be others:

{noformat}
if (foo)
{ 
  /* ... */
}
else
{
  /* ... */
}

{noformat}

should be:

{noformat}

if (foo) {
 /* ... */
} else {
 /* ... */
}

{noformat}

And:

{noformat}

if (foo)
  bar;

{noformat}

should be:

{noformat}

if (foo) {
  bar;
}

{noformat}
                
> A Module to Submit CDR via Curl to a webservice end point
> ---------------------------------------------------------
>
>                 Key: ASTERISK-20599
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20599
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Functions/func_curl
>    Affects Versions: 10.2.1
>            Reporter: Alex
>            Assignee: Rusty Newton
>            Severity: Minor
>         Attachments: cdr_curl.c, cdr_curl.conf
>
>
> A Module to Submit CDR via Curl to a webservice end point.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira