[asterisk-bugs] [JIRA] (ASTERISK-20457) GSM encoding is not thread safe

[Jonathan Rose (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=198840#comment-198840 ] 

Jonathan Rose commented on ASTERISK-20457:
------------------------------------------

Thanks for the patch, I just dropped it on the SVN.
                
> GSM encoding is not thread safe
> -------------------------------
>
>                 Key: ASTERISK-20457
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20457
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Codecs/codec_gsm
>    Affects Versions: 1.8.16.0, 10.8.0, 11.0.0-beta2
>            Reporter: Richard Miller
>            Assignee: Jonathan Rose
>         Attachments: code.diff, code.patch, code.patch
>
>
> The file codecs/gsm/src/code.c uses a static variable "e" that it is passing down into a lower level function.  The original author in patch level 12 moved it into the gsm_state structure, but that really isn't necessary.  All that needs to be done is to make it a temporary local variable by removing the "static" qualifier.  The bug does not affect decoding, only encoding.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira