[asterisk-bugs] [JIRA] (ASTERISK-20561) Asterisk 1.8 allows the # character in SIP URI, 10 and higher versions do not - need to document in UPGRADE.txt possibly other places?

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=198750#comment-198750 ] 

Matt Jordan commented on ASTERISK-20561:
----------------------------------------

Looking back at the commit message (r303509) and the review (https://reviewboard.asterisk.org/r/1081/), I'm sure that's why it was done that way.  Tilghman's comment "Excellent work.  You addressed exactly the concerns I had with modifying that function yet again." says a lot about the risk associated with modifying that function in a release branch.

I'd say the correct action here is to update the UPGRADE file in the appropriate versions and not backport the patch to 1.8.
                
> Asterisk 1.8 allows the # character in SIP URI, 10 and higher versions do not - need to document in UPGRADE.txt possibly other places?
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-20561
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20561
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/General
>    Affects Versions: 1.8.17.0
>            Reporter: Deniz
>
> When setting CALLERID(num)=#0012345678 asterisk is generating from-header:
> from: <sip:#0012345678 at 192.168.110.12>
> My understanding of RFC 3261 usernames are just allowed to contain alphanumeric characters, escape-sequences and some special characters (which do not include #).
> RFC 3261 refers to rfc2396 for more details which describes # as delimiter and not allowed to be part of URI.
> So, this character has to be replaced by "%23".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira