[asterisk-bugs] [JIRA] Issue Comment Edited: (ASTERISK-17362) Unsolicited SIP notifies cannot be routed to MWI lights on individual phones

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-17362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=198409#comment-198409 ] 

Matt Jordan edited comment on ASTERISK-17362 at 10/12/12 4:59 PM:
------------------------------------------------------------------

There are several ways this can get integrated into trunk.  Note that because its a new feature, it is not a candidate for inclusion in any release branch (1.8, 10, or 11).
# Eventually, it will be assigned to a Digium developer to evaluate and review.  At that time, it will be integrated into what is at the time trunk.  When trunk is turned into a new release of Asterisk, it will be included in that version.  I do not have a time estimate as to when that will occur.
# An Asterisk developer may decide they like this feature and take it on for free.  They will then shephard the patch through the process.
## Alternatively, you can pay an Asterisk developer to do that.  The asterisk-biz mailing list is the appropriate place to look for a developer.
## Alternatively, someone can clean up this patch and write it for the current trunk.  That leads us to...
# Someone else (not a Digium developer, not an Asterisk community developer) can clean up this patch for inclusion.  While that doesn't necessarily mean it will be committed, it can possibly make the process go a bit faster.  In general, patches that have been (a) well tested, (b) follow the coding guidelines [1], (c) can be verified to be 'correct' and non-intrusive based on a cursory code inspection, will be addressed much faster than patches that don't meet that criteria.  If you decide to go down that road, you can contact developers in the #asterisk-dev channel.

[1] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines

      was (Author: mjordan):
    There are several ways this can get integrated into trunk.  Note that because its a new feature, it is not a candidate for inclusion in any release branch (1.8, 10, or 11).
# Eventually, it will be assigned to a Digium developer to evaluate and review.  At that time, it will be integrated into what is at the time trunk.  When trunk is turned into a new release of Asterisk, it will be included in that version.  I do not have a time estimate as to when that will occur.
# An Asterisk developer may decide they like this feature and take it on for free.  They will then shephard the patch through the process.
## Alternatively, you can pay a developer to do that.  The asterisk-biz mailing list is the appropriate place to look for a developer.
## Alternatively, someone can clean up this patch.  That leads us to...
# Someone else (not a Digium developer, not an Asterisk community developer) can clean up this patch for inclusion.  While that doesn't necessarily mean it will be committed, it can possibly make the process go a bit faster.  In general, patches that have been (a) well tested, (b) follow the coding guidelines [1], (c) can be verified to be 'correct' and non-intrusive based on a cursory code inspection, will be addressed much faster than patches that don't meet that criteria.  If you decide to go down that road, you can contact developers in the #asterisk-dev channel.

[1] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
  
> Unsolicited SIP notifies cannot be routed to MWI lights on individual phones
> ----------------------------------------------------------------------------
>
>                 Key: ASTERISK-17362
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-17362
>             Project: Asterisk
>          Issue Type: New Feature
>          Components: Channels/chan_sip/NewFeature
>            Reporter: Clinton Goudie-Nice
>         Attachments: patch-1.8.7.1-chan_sip-unsolicited-notify-handling.jira-bug-17362.diff.txt, patch-chan_sip-unsolicited_notify_routing.diff.txt, patch-chan_sip-unsolicited_notify_routing.diff.txt, sipsample.txt
>
>
> Currently, the implementation for unsolicited_mailbox routes all inbound unsolicited sip notifies to a single mailbox at the hard coded context SIP_Remote.
> This makes it impossible for 3rd party SIP integrations to light MWI lights on phones attached to Asterisk. This is critical for 3rd party applications such as voicemail and IVR systems (IE: Exchange UM and Callware Callegra) to fully integrate with Asterisk as they can with other PBX systems such as Cisco Unified Communications Manager. 
> For these types of integrations, Asterisk needs the ability to receive unsolicited SIP notifies and route them as MWI lights to the appropriate physical device, within a context defined per trunk. This needs to occur without breaking anyone relying on the current Asterisk functionality of routing all unsolicited sip notifies to a single box.
> The submitted patch handles this as follows:
> If unsolicited_mailbox is unset, unsolicited notifies are not delivered anywhere.
> If unsolicited_mailbox=somebox all unsolicited notifies will be delivered to somebox at SIP_Remote to preserve existing functionality.
> If unsolicited_mailbox=somebox at somecontext all unsolicited notifies will be delivered to somebox at somecontext
> If unsolicited_mailbox=@somecontext the box from the sip notify will be used to deliver the sip notify to the specified box at somecontext.
> The box is specified either through the Message-Account portion of the body, and if unspecified there, the To header, as specified in RFC3842. 
> Additionally, this patch adds debug logging so that an end user can troubleshoot unsolicited sip notify issues by turning on debug logging.
> ****** ADDITIONAL INFORMATION ******
> This issue supersedes issue 18736. Thanks also go to cmaj for his submission of the UM patch and additional guidance as we created this patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira