[asterisk-bugs] [JIRA] Created: (ASTERISK-20534) Odd happenings in inotify and kqueue code with spool files.

[Rusty Newton (JIRA)]

Odd happenings in inotify and kqueue code with spool files.
-----------------------------------------------------------

                 Key: ASTERISK-20534
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20534
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: PBX/pbx_spool
    Affects Versions: 1.8.18.0
            Reporter: Richard Mudgett


While working on ASTERISK-17231 I came across some odd behavior.  When INOTIFY and KQUEUE support was added, a warning message was conditionaled out.  I added the todo comment to indicate that something strange is going on.  Further investigation is needed to determine if there is a better way to do this since call files may be processed erroneously.

{code:title=pbx/pbx_spool.c}
	/* Attempt to open the file */
	f = fopen(o->fn, "r");
	if (!f) {
#if defined(HAVE_INOTIFY) || defined(HAVE_KQUEUE)
		/*!
		 * \todo XXX There is some odd delayed duplicate servicing of
		 * call files going on.  We need to suppress the error message
		 * if the file does not exist as a result.
		 */
		if (errno != ENOENT)
#endif
		{
			ast_log(LOG_WARNING, "Unable to open %s: '%s'(%d), deleting\n",
				o->fn, strerror(errno), (int) errno);
		}
		remove_from_queue(o, "Failed");
		free_outgoing(o);
		return -1;
	}
{code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira