[asterisk-bugs] [JIRA] Closed: (ASTERISK-17231) [patch] unopenable spool files not deleted

[Digium Subversion (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Digium Subversion closed ASTERISK-17231.
----------------------------------------

    Resolution: Fixed

> [patch] unopenable spool files not deleted
> ------------------------------------------
>
>                 Key: ASTERISK-17231
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-17231
>             Project: Asterisk
>          Issue Type: Bug
>          Components: PBX/pbx_spool
>            Reporter: David Chappell
>            Assignee: Richard Mudgett
>            Severity: Minor
>         Attachments: spool_open_failure.diff
>
>
> If scan_service() cannot open the spool file, it logs a message saying that it will delete the file and calls remove_from_queue() to do it. However, remove_from_queue() fails to delete the spool file because struct outgoing has not yet been fully initialized.
> I have attached a patch which fixes this by calling unlink() instead of remove_from_queue().
> (The patch makes two other minor changes: 1) fixes a garbled comment and 2) moves a log messages so that it actually comes before the operation which it says is about to be performed.)
> I am not sure that my patch represents the best way to fix this. For example, it might be better to fill in o->fn earlier so that an attempt can be mode to move the unopenable spool file into the archive directory.
> ****** STEPS TO REPRODUCE ******
> Create a spool file with permissions which do not permit the user under which the Asterisk daemon is running to open it for reading.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira