[asterisk-bugs] [JIRA] (ASTERISK-20674) nat=force_rport, comedia does not behave the same as nat=yes

[Walter Doekes (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=200154#comment-200154 ] 

Walter Doekes commented on ASTERISK-20674:
------------------------------------------

?

That patch looks like a no-op to me.
{noformat}
 		} else if (!strcasecmp(this, "force_rport") && !ast_test_flag(&flags[2], SIP_PAGE3_NAT_AUTO_RPORT)) {
 			ast_set_flag(&flags[0], SIP_NAT_FORCE_RPORT);
+			/* In case someone did something dumb like nat=auto_force_rport,force_rport */
+			ast_clear_flag(&flags[2], SIP_PAGE3_NAT_AUTO_RPORT);
{noformat}

IF NOT isset(SIP_PAGE3_NAT_AUTO_RPORT) THEN unset(SIP_PAGE3_NAT_AUTO_RPORT) ?
                
> nat=force_rport,comedia does not behave the same as nat=yes
> -----------------------------------------------------------
>
>                 Key: ASTERISK-20674
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20674
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/Configuration
>    Affects Versions: 11.0.1
>         Environment: Gentoo Linux 64 bit PowerPC, kernel 3.6.1, GCC 4.5.3
>            Reporter: headphones
>            Assignee: Kinsey Moore
>            Severity: Minor
>         Attachments: ASTERISK-20674.diff, Asterisk-debug-1-nat-yes-outgoing.log, Asterisk-debug-2-nat-yes-incoming.log, Asterisk-debug-3-nat-forcerportcomedia-outgoing.log, Asterisk-debug-4-nat-forcerportcomedia-incoming.log
>
>
> After an upgrade from 1.8.17.0 to 11.0.1 we get warnings about the deprecation of nat=yes in sip.conf:
> {{\[Nov 10 14:02:14\] WARNING\[28487\]: sip/config_parser.c:812 sip_parse_nat_option: nat=yes is deprecated, use nat=force_rport,comedia instead}}
> If we change to nat=force_rport,comedia the behavior seems to be fine, except for outside users behind NAT. Our server is also behind NAT.
> When an outside NAT:ed user calls in to the network everything works as expected, but when calling the outside user, or when two outside NAT:ed users call each other, the audio only goes one way without any errors shown in the console. When changing back to nat=yes, everything work again.
> By looking in the source code for sip/config_parser.c, it seems like the reason for the difference is that when using sip=yes, the auto_force_rport and auto_comedia are cleared from &flags\[2\]. However, when using force_rport,comedia, the auto equivalents are not cleared away.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira