[asterisk-bugs] [JIRA] (ASTERISK-16735) bad dialog-info remote information

[Matt Jordan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-16735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=199908#comment-199908 ] 

Matt Jordan edited comment on ASTERISK-16735 at 11/20/12 9:20 PM:
------------------------------------------------------------------

Unfortunately what is currently implemented in 11.1.0-rc1 doesn't work with Polycom phones. Asterisk sends two NOTIFY messages where the first contains the incorrect caller ids followed by one with the correct ones. Polycom phones do not update the display however. See http://community.polycom.com/t5/VoIP/Busy-Lamp-Field-Caller-IDs-not-updated/td-p/24080

The following small patch for 11.1.0-rc1 prevents the first incorrect SIP NOTIFY message from being sent if notifycid is set:

[edit - removed inline code - mjordan]

See also: http://community.polycom.com/t5/VoIP/Busy-Lamp-Field-Caller-IDs-not-updated/m-p/24090
                
      was (Author: srt):
    Unfortunately what is currently implemented in 11.1.0-rc1 doesn't work with Polycom phones. Asterisk sends two NOTIFY messages where the first contains the incorrect caller ids followed by one with the correct ones. Polycom phones do not update the display however. See http://community.polycom.com/t5/VoIP/Busy-Lamp-Field-Caller-IDs-not-updated/td-p/24080

The following small patch for 11.1.0-rc1 prevents the first incorrect SIP NOTIFY message from being sent if notifycid is set:

{code:none}
--- channels/chan_sip.c	2012-11-02 17:24:01.000000000 +0000
+++ /usr/local/src/asterisk-11.1.0-rc1/channels/chan_sip.c	2012-11-20 04:16:36.598351049 +0000
@@ -14411,6 +14411,8 @@
 
 					ast_channel_unlock(callee);
 					callee = ast_channel_unref(callee);
+				} else {
+					break;
 				}
 
 				/* We create a fake call-id which the phone will send back in an INVITE
{code}

See also: http://community.polycom.com/t5/VoIP/Busy-Lamp-Field-Caller-IDs-not-updated/m-p/24090
                  
> bad dialog-info remote information
> ----------------------------------
>
>                 Key: ASTERISK-16735
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-16735
>             Project: Asterisk
>          Issue Type: Bug
>          Components: Channels/chan_sip/Subscriptions
>            Reporter: Maciej Krajewski
>            Severity: Minor
>         Attachments: 16735-tweak1.diff, 16735-tweak2.diff, local_remote_hint2.diff, local_remote_hint.diff
>
>
> Enabling "notifycid" to "yes" is making asterisk to send NOTIFY information about callid in dialog-info section. In this dialog, asterisk also sends information about local and remote side. I found that data about remote side are the same as in the local side, witch is obviously wrong, according to RFC4235.
> Beneath is an example of such dialog.
> ****** ADDITIONAL INFORMATION ******
> <?xml version="1.0"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="6" state="full"
> entity="sip:test001 at 10.0.0.12">
> <dialog id="test001" call-id="pickup-ca245a55-3b1618d9 at 172.16.0.84" direction="recipient">
> <remote>
> <identity display="test001">sip:test001 at 10.0.0.12</identity>
> <target uri="sip:test001 at 10.0.0.12"/>
> </remote>
> <local>
> <identity>sip:test001 at 10.0.0.12</identity>
> <target uri="sip:test001 at 10.0.0.12"/>
> </local>
> <state>early</state>
> </dialog>
> </dialog-info>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira