[asterisk-bugs] [JIRA] (ASTERISK-20462) Trunk not hungup if SLA Station hangs up before answer

[dkerr (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=199547#comment-199547 ] 

dkerr edited comment on ASTERISK-20462 at 11/11/12 11:06 AM:
-------------------------------------------------------------

While debugging this I notice that the section of code I am changing is inside a tight loop... for ( ; ; ) and it goes round and round thousands of times.  Something of a CPU hog.

Would it not be better to sleep for 100ms before checking again? Checking 10 times a second would seem to be rapid enough.

To check this theory out I put...
ast_safe_sleep(trunk_ref->chan, 100);
and it seems to work just fine.  However I did not include this in any of my patches because maybe there is a good reason that the original developer had such a tight loop.

Just a thought.
David

                
      was (Author: dkerr):
    While debugging this I notice that the section of code I am changing is inside a tight loop... for (;;) and it goes round and round thousands of times.  Something of a CPU hog.

Would it not be better to sleep for 100ms before checking again? Checking 10 times a second would seem to be rapid enough.

To check this theory out I put...
ast_safe_sleep(trunk_ref->chan, 100);
and it seems to work just fine.  However I did not include this in any of my patches because maybe there is a good reason that the original developer had such a tight loop.

Just a thought.
David

                  
> Trunk not hungup if SLA Station hangs up before answer
> ------------------------------------------------------
>
>                 Key: ASTERISK-20462
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20462
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_meetme, Applications/SLA
>    Affects Versions: 1.8.15.0
>         Environment: Astlinux
>            Reporter: dkerr
>         Attachments: asterisk-1.8-bugid20462.patch, asterisk-trunk-bugid20462.patch, extensions.conf, Hangup before answer.txt, sip.conf, sla.conf
>
>
> If an SLA station hangs up before the called party answers, then the channel to the sla station is terminated, but the channel to the called party remains open and continues to ring until timeout. Or if the party answers then they get unobtainable tone and asterisk fails all over trying to connect to a meetme conference that does not exist.
> See attached log file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira