[asterisk-bugs] [JIRA] (ASTERISK-20649) Patches for memory leaks and other cleanup across several files

[Corey Farrell (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Farrell updated ASTERISK-20649:
-------------------------------------

    Attachment: unregister-cli-multiple-all.patch
                udptl-shutdown-11-trunk.patch
                udptl-shutdown-1_8-10.patch
                taskprocessor-cleanup-10-only.patch
                taskprocessor-cleanup-1_8-11-trunk.patch
                ssl_shutdown-1_8-10.patch
                pbx-cleanup-11-trunk.patch
                pbx-cleanup-10.patch
                pbx-cleanup-1_8.patch
                logger-cleanup-all.patch
                indications-cleanup-all.patch
                frame-cleanup-1_8-only.patch
                event_shutdown-10-only.patch
                event_shutdown-1_8-11-trunk.patch
                dnsmgr-cleanup-10-11-trunk.patch
                dnsmgr-cleanup-1_8.patch
                db-cleanup-1_8-only.patch
                core-cleanup-11-trunk.patch
                core-cleanup-1_8-10.patch
                config-cleanup-all.patch
                cli-leaks-11-trunk.patch
                cli-leaks-1_8-10.patch
                cdr-cleanup-10-11-trunk.patch
                cdr-cleanup-1_8.patch
                ccss-cleanup-all.patch

Corrected patches using [source_name]_shutdown for exit procedures.  Patches were checked against 1.8/10/11/trunk.  This does not resolve all shutdown's.

* I'm not sure how the patch for ssl shutdown applies to 11 or trunk.  I haven't had a chance to figure out libasteriskssl.
* These patches only address issues found in 1.8.
* event and taskprocessor for branch 10 have additional fixes, the shutdown for these sources was somehow not applied to version 10.
* I haven't touched features.c yet.
* Enabling DEBUG_THREADS produces a huge number of memory leaks due to locks not being destroyed.
                
> Patches for memory leaks and other cleanup across several files
> ---------------------------------------------------------------
>
>                 Key: ASTERISK-20649
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20649
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General
>    Affects Versions: 1.8.17.0
>            Reporter: Corey Farrell
>            Assignee: Matt Jordan
>            Severity: Minor
>         Attachments: ccss-cleanup-all.patch, cdr-cleanup-10-11-trunk.patch, cdr-cleanup-1_8.patch, cli-leaks-11-trunk.patch, cli-leaks-1_8-10.patch, config-cleanup-all.patch, core-cleanup-11-trunk.patch, core-cleanup-1_8-10.patch, db-cleanup-1_8-only.patch, dnsmgr-cleanup-10-11-trunk.patch, dnsmgr-cleanup-1_8.patch, event_shutdown-10-only.patch, event_shutdown-1_8-11-trunk.patch, frame-cleanup-1_8-only.patch, indications-cleanup-all.patch, logger-cleanup-all.patch, pbx-cleanup-10.patch, pbx-cleanup-11-trunk.patch, pbx-cleanup-1_8.patch, ssl_shutdown-1_8-10.patch, taskprocessor-cleanup-10-only.patch, taskprocessor-cleanup-1_8-11-trunk.patch, udptl-shutdown-11-trunk.patch, udptl-shutdown-1_8-10.patch, unregister-cli-multiple-all.patch
>
>
> Valgrind reports memory still allocated at exit.  Patches will follow to address many of these issues against branch 1.8.
> ||Source||Issues||
> |many|CLI commands not unregistered|
> |ccss.c|Logger level not unregistered|
> |cdr.c|No cleanup at exit|
> |cli.c|Command registration leaks memory on some error's|
> |config.c|Config cache not cleared|
> |db.c|No cleanup at exit|
> |dnsmgr.c|No cleanup at exit|
> |indications.c|Sounds leaked when removed from zone
> Ringcadence allocated twice causing leak
> Shutdown incomplete|
> |logger.c|close_logger incomplete|
> |pbx.c|device_state_tps, hints and statecbs keep references|
> |ssl.c|No cleanup at exit|
> |asterisk.c|ast_run_atexits doesn't cleanup atexits list
> Shutdown from cli causes ast_cli_entry to be inuse
> Verbose runs ast_active_channels() after channels_shutdown|
> |stdtime/localtime.c|No cleanup.  Cleanup needs to be done after logger cleanup|

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira