[asterisk-bugs] [JIRA] (ASTERISK-20486) MeetMe Unable to write frame to channel after SIP channel hangs up.

[Jonathan Rose (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-20486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Rose updated ASTERISK-20486:
-------------------------------------

    Attachment: meetme_hangup_patch_ASTERISK-20486_v3.diff

Alright, I think for the rest of these issues we are just going to reintroduce the hangup check before the ast_waitfor_nandfds function is used. Mark and I went over Russell's commit log and he removed that bit simply because it no longer appeared to be necessary, and it seems it actually was.  We can't find any real problematic issues causing this problem aside from possibly the timerfd thing in some of the cases and it also is caught by the hangup check.  We'll keep our eyes on that one.

I thought about adding a bunch of bailout conditions for every streamfile function since having multiple of those in a single pass of the loop without bailing out on the exit condition produces a warning, but the changes seem a little severe just to keep a more or less harmless warning from occurring in MeetMe.  The newest patch does however fix a small problem with menus not checking the response of the DTMF while hanging up the menus. It ends up using the 'default' case when the user hangs up because DTMF gets set to -1.  To address that I just made the menus only respond to positive values for dtmf (which should cover every valid DTMF a phone can send anyway).

The new patch I'd like people concerned with these issues to try is meetme_hangup_patch_ASTERISK-20486_v3.diff