[asterisk-bugs] [JIRA] Issue Comment Edited: (ASTERISK-20145) Segfault in iax_pvt_callid_get

[Jonathan Rose (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=195071#comment-195071 ] 

Jonathan Rose edited comment on ASTERISK-20145 at 7/20/12 2:36 PM:
-------------------------------------------------------------------

This was just a bad assumption on my part. I think I must have thought that taking the lock meant a channel was in that position. Looking at where I had invoked iax_pvt_callid_get, it's pretty clear that this isn't the case and it's still possible for a call to 'arrive for a nonexistent destination'.

Fix is trivial, I just need to check for the presence of the channel before trying to get a call ID out of it.

EDIT: I committed a fix. It shouldn't be able to happen anymore.

      was (Author: jrose):
    This was just a bad assumption on my part. I think I must have thought that taking the lock meant a channel was in that position. Looking at where I had invoked iax_pvt_callid_get, it's pretty clear that this isn't the case and it's still possible for a call to 'arrive for a nonexistent destination'.

Fix is trivial, I just need to check for the presence of the channel before trying to get a call ID out of it.
  
> Segfault in iax_pvt_callid_get
> ------------------------------
>
>                 Key: ASTERISK-20145
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20145
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_iax2
>    Affects Versions: SVN
>            Reporter: Birger "WIMPy" Harzenetter
>         Attachments: pastebin
>
>
> This happened after a call was terminated.
> I have no idea what contributed to this happening and cannot reproduce, but a segfault is always bad.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira